Input-leap fedora 39 GNOME Wayland

chrisawi · November 14, 2023, 7:04am

Did you install libportal from that COPR as well? Fedora’s libportal doesn’t yet have

github.com/flatpak/libportal

Add support for the InputCapture portal

flatpak:main ← whot:wip/inputcapture

opened 07:21AM - 02 Jun 22 UTC

whot

+3328 -174

For the corresponding Portal PR, please see https://github.com/flatpak/xdg-deskt…op-portal/pull/714 This is a draft PR to add support for the input capture portal. Most of it is straightforward portal implementation but this portal does have a larger surface and more state than most, which raises a few questions: - [ ] ~~`XdpSession` is re-used for input capture portals now too. This makes namespacing (or the lack thereof) slightly awkward, e.g. the `activated` signal on the session is instead `inputcapture-activated` to avoid future conflicts, which then requires the other signals to be namespaced too.~~ - ~~ideally we'd have a `XdpInputCaptureSession` as subclass of `XdpSession` but the latter is declared final right now and I'm not 100% if that's an ABI break then.~~ edit: this was nacked in #102 - [ ] `XdpInputCaptureSession` now *contains* an `XdpSession` and the API is namespaced properly. - [x] The `enable`/`disable`/`release` methods ~~are paired with their respective `_finish`, but tbh this is of questionable value. Even if the portal keeps these as requests, I'd argue hiding this away here would make for better API - we can use the session signals to notify the caller out-of-band.~~ Update June 06: these are method calls now - [ ] the pointer barriers and capture zones have their own GObjects with properties and little other functionality. This makes for slightly more sensible API but it also conflicts a bit with e.g. `XdpSession` which doesn't have properties but setters/getters only. - [x] the `Disabled` signal is still missing here I just noticed - [x] there's a dbusmock/pytest based test suite included. ~~that won't run without patched dbus-python and dbusmock~~ but it makes testing *so* much easier. specifically, it allows to test libportal without an existing implementation of the actual portal. Merged to main in #99, this is just the inputcapture tests now The above are the larger topics, I'd appreciate a high-level review of the API and suggestions for where to go with this. cc @jadahl

Topic		Replies	Views
Sway polkit on f37 does not work? Ask Fedora f37 , wayland , sway , polkit	3	2081	November 19, 2022
Having trouble while building libinput manually Ask Fedora f36 , wayland , driver	7	755	May 27, 2022
After Update to F39, org.gnome.Shell@wayland.service fails with SIGSEV Ask Fedora wayland , amd , gnome , f39 , server	2	399	December 19, 2023
Wayland fails after F37 upgrade Ask Fedora f37 , wayland , mesa , intel	5	521	November 20, 2022
Lost ability to log in wayland + nvidia Ask Fedora wayland , nvidia , silverblue	1	723	May 15, 2021

Input-leap fedora 39 GNOME Wayland

Related topics