Two handy Bash aliases to quickly review a Pagure pull request

jflory7 · March 25, 2019, 8:10pm

Hi all! Last week, I found myself questioning why I spend so much time running the same few git commands whenever I want to quickly review and test a pull request to a project I maintain. I thought I would share these aliases I added to my .bashrc file to speed up my PR reviews:

github.com

jwflory/swiss-army/blob/23cbf4545bc16f4908f805135c9f6550ec40f071/roles/apps/bash/files/bashrc#L48-L68


      
          # Pagure pull request, non-master branch
          function pag_pull_nm {
              git checkout master
              git branch -D $2
              git fetch origin pull/$1/head:$2
              git checkout $2
          }
          
          
# Pagure pull request, master branch
          function pag_pull_m {
              git checkout master
              git branch -D pr-$1
              git checkout -b pr-$1
              git fetch origin pull/$1/head:master -f
              git checkout master
              git branch -D pr-$1
              git checkout -b pr-$1
              git checkout master
              git reset --hard origin/master
              git checkout pr-$1
          }

The top command is for reviewing a pull request where someone used a feature branch (i.e. nm == non-master). It takes two positional arguments: the PR number and the name of the contributor’s feature branch. The bottom command is for reviewing a pull request where someone committed on the master branch. It takes one positional argument of the PR number. For both commands, it assumes you are already in the directory of the Pagure project you wish to review.

Anyways, these were handy quick “hacks” for me and thought someone else might be able to make use of them too.

bcotton · March 26, 2019, 1:29pm

This would make a good CommBlog post. Just saying…

jflory7 · March 27, 2019, 12:44am

Nice idea. I wrote up a draft and scheduled it for April 9th. An early preview link is here:

Topic		Replies	Views
How to open pull requests for Fedora package repositories at src.fedoraproject.org Ask Fedora pagure , packages , contributing	4	681	August 29, 2021
Docs contributor guide updated Project Discussion docs-team	2	207	March 25, 2023
Source-git SIG report #1 Community Blog	0	316	July 1, 2021
Pagure Web UI for Docs contribution Project Discussion docs-team	6	330	April 23, 2023
[Poll] What is your preferred way to Pull Request review? Project Discussion jam-team , engineering , package-maintainers , docs-team	10	268	January 24, 2024

Two handy Bash aliases to quickly review a Pagure pull request

Related topics