String REPLACE CMAKE_CXX_FLAGS causes package build to fail

Project Discussion
1

Upon re-building the package latte-dock, I came upon an issue I don’t quite understand. In the new
release, upstream added the following to CMakeFiles.txt:

string(REPLACE “-Wall” “” CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
string(REPLACE “-Wformat-security” “” CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})

The addition of these lines cause the build to fail with multiple errors from:
Werror=format-security

If I deleted:
string(REPLACE “-Wall” “” CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
string(REPLACE “-Wformat-security” “” CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})

the package built normally. I also found that if I kept the above lines in and added:
string(REPLACE “-Werror=format-security” “” CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})

the package built normally. I spoke to upstream, apparently no other distributions are having this issue, just Fedora.

Can anyone explain why this is occuring? Thanks very much!

2

What sort of failures?

Regardless of that though, 1) as a C, and sometimes C++, programmer, that sounds really annoying; if I set -Wall in my flags, I want them, and not have the project randomly decide to ignore it (this doesn’t apply to all warnings, like unused parameter warnings), and 2) builds on Fedora must use the flags, so you need to patch that out anyway.