Packagers: spec file not found in srpm after build, fails auto review

Ask Fedora
1

Hey all!

Started putting together a few packages and opened up my requests for review. There’s only one thing really getting in my way right now, and I was hoping y’all could advise.

Fedora review failed
err:
INFO: Processing local files: python-sherlock
INFO: Getting .spec and .srpm Urls from : Local files in /var/lib/copr-rpmbuild/results
INFO:   --> SRPM url: file:///var/lib/copr-rpmbuild/results/python-sherlock-0.14.4-1.fc41.src.rpm
INFO: Using review directory: /var/lib/copr-rpmbuild/results/python-sherlock
ERROR: 'Cannot find spec file in srpm' (logs in /var/lib/copr-rpmbuild/results/cache/fedora-review.log)

Full copr build log here, but I doubt it’s necessary. Of more value may be the spec file, which can be found here.

I feel like there’s a critical step that I’m forgetting. Only happens on this one package. The error message sounds extremely obvious but it’s just slipping by me.

Note that the build succeeds perfectly fine and the package is perfectly functional, it’s only the fedora-review that fails.

Thanks!

2

I think that it may be caused by the unmatchness between the Spec file name sherlock.spec and package name python-sherlock. Maybe switching the package name to sherlock.

3

I actually tried that as well, and it presented the same error :confused:

I was surprised when it didn’t work with the matching name

4

Wait, I misread. I renamed the spec file to python-sherlock.spec in my testing.

Let me try changing the package name just to see. Can’t publish it that way due to naming conventions, but it’d help narrow it down if something changes

5

so… it turns out that this only happens when building from scm. it pulls the spec properly from github, but then it doesn’t include it in the srpm.

when uploading the spec manually, it includes it just fine.

odd…but as long as one method works I guess I can address it in a bit