RHBZ#2143020 Review Request: lua-linenoise - A binding for the linenoise command line library

Team Workflows Package Review Swaps
1

Bugzilla #2143020

Description: Linenoise (GitHub - antirez/linenoise: A small self-contained alternative to readline and libedit) is a delightfully simple
command line library. This Lua module is simply a binding for it.

The main Linenoise upstream has stagnated a bit, so this binding tracks
GitHub - yhirose/linenoise: A small self-contained alternative to readline and libedit, which includes things
like UTF-8 support and ANSI terminal escape sequence detection.
Complexity: Medium

2

Review is done:

  • This needs to be SPDX:

# Binding is MIT license and bundled linenoise is BSD
License: MIT AND BSD

→

License: MIT AND BSD-2-Clause

  • You don’t seem to use the Makefile so this is probably not needed:

BuildRequires: make

  • please use autorelease/autochangelog

  • put the %forgemeta below the %global definition

Get back to me with NEEDINFO when the SPEC is fixed.

1 Like
3

Package approved.

Please mark this post as solution.

1 Like
4

Thank you!

5

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.