Pagure Web UI for Docs contribution

This is about editing pages in pagure.io

I am trying to following this guide: https://docs.fedoraproject.org/en-US/fedora-docs/contributing-docs/tools-file-edit-pagure/#_editing_online_in_pagure

I think I am done with Step 5. But not sure how to do step 6. As in the UI, I cannot locate “Create pull request”

https://pagure.io/fork/sampsonf/fedora-workstation/blob/f73a9641411c8002170d94cc35e263d765c1d2cd/f/user-docs/modules/ROOT/pages/index.adoc#

Hi, please find the open PR button on top right where you will see menu to select your fork and branch.

You committed successfully. :party: :tada:

You need to create PR to complete your part. Then reviewers will check the PR request and give you feedback (approve and merge or ask you to revise and improve if anything not sufficient).

The Pagure PR guide was brought back to life only on 22 April. I was contemplating to add images, but pushed the text first. Please let me know how you get on.

Maybe, we need a separate thread for Docs contributor onboarding, something like that.

I see 4 items from the Open PR button:

image

Which one I should choose?

Check New Pull Request and you will see source branch and target branch. You’re close to the finish line.

I see PR made. Looks good to me. I can’t merge PR because I don’t have write access to the repo to merge. Wait for admin group to see your PR and get back to you.

2 Likes

Maybe a requirement of all docs repos should be that members of the core docs team should have write access to them? Similar to “proven packagers” to ensure that minor changes don’t have to wait for individual teams to be merged/fixed?

As the policy notes, these powers are only rarely used, but they’re very useful.

Thanks @ankursinha , could you split contents related to Pagure PR as a new thread?

Maybe a requirement of all docs repos should be that members of the core docs team should have write access to them? Similar to “proven packagers” to ensure that minor changes don’t have to wait for individual teams to be merged/fixed?

I think the workflow is there within reason and expected behavior. It’s fine for me. I just let Sampson know the ball is on workstation team.

1 Like

Done. Let me know if I shall change the topic name or so.