Just made wrote my first kernel patch, I'm not sure if it's good so i would like people help in reviewing it

Ask Fedora
1

Source: svin/amd_sfh_envy - Codeberg.org

It’s an issue i had with my laptops’ rotation features due to a bad UEFI upgrade by HP.

Ideally i would love to have it upstreamed but frankly i have no idea what the process is.
Of if it’s good enough and I’m doing something stupid.

I know it works on my laptop at least.

I did ask an AI for help with this particularly regarding finding the issue, and how to make the patch files less noisy.

To summarize: on the HP ENVY x360 15-eu0xxx after after BIOS F.12(I can’t downgrade), Linux only sees gyro and magnetometer. So screen rotation does not work.

I have tested this on Fedora 44 with my HP envy laptop.

2

I think getting appropriate review of that belongs to the devel mailing list or the devel channel, I would suggest the devel mailing list though (so the second option below):

#devel:fedoraproject.org (if you have no matrix, you can use the Fedora web client with your existing Fedora account: https://chat.fedoraproject.org/#/room/#devel:fedoraproject.org )

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org (sign up at the top right; the same: you can use your existing FAS account)

I expect you want to file this patch upstream?

In any case, you might want to add a LICENSE file :classic_smiley:

(the code is not written by AI, right?)

3

A kernel patch should probably go to those responsible for the upstream component being patched. In general, changes should work in way that isn’t tied to specific hardware models. A bit of research may find others working on the same problem.

Edit: https://www.phoronix.com/news/Linux-7.3-HID adds support “expose accelerometer, gyroscope, and touch grip data directly through the kernel”.

4

the quirk (0001) no but the second part had some heavy editing because I was completely unaware of how to do it.

I just wanted to make a post here because I’m completely unaware of what the process is and it’s been bugging me for like 2 years. Plus i’m not sure if this is considered acceptable for the kernel.

5

Well, it’s ok to ask in the community for feedback & review before submitting upstream. Concerning where and how, see my last post.

But I expect this will have to be submitted upstream: in short, patching the Fedora kernel is generally avoided in favor of getting stuff merged upstream.

The most important documentation for you will be likely the docs.kernel.org , and I suggest to check out the regulations about using AI. There are also many articles (e.g., lwn) about that, as much of that has just been discussed about how to handle it and what to allow and what not.

I suggest to work through the kernel docs (mostly, the submitting patches parts and AI-related parts, e.g., AI Coding Assistants)