$ sudo grub2-mkconfig -o /boot/grub2/grub.cfg
Generating grub configuration file ...
grub2-probe: error: cannot find a GRUB drive for /dev/sdb3. Check your device.map.
Found Windows Boot Manager on /dev/nvme0n1p1@/EFI/Microsoft/Boot/bootmgfw.efi
Adding boot menu entry for UEFI Firmware Settings ...
done
not a significant error. It sees the usb drive which is not needed now.
Now to look at the next part. ls /boot/loader/entries and find the file that shows the 5.19.6 kernel.
then grep that file for the rd.lvm.lv entry to see if it has the old VG name or the new one.
verify that everything under /boot/efi/EFI/fedora was gone
Verify that /boot/grub2/grub.cfg was removed
Rename the VG (may or may not have been necessary, but was not activating at all when booted to the live USB system)
The windows install created a new UUID for the ESP. That plus renaming the VG required an edit of /etc/fstab with the new info required for booting.
Reinstall both grub2* and shim* (to rebuild all the files under /boot/efi/EFI/fedora)
run efibootmgr -c to tell the UEFI bios that grub was available to boot.
Renaming the VG necessitated an edit of /etc/default/grub to put the new VG name in the kernel command line.
A final run of grub2-mkconfig -o /boot/grub2/grub.cfg put the updated kernel command line in all the boot loaders for fedora and booting is now working properly.
If that is the gist as you see it then I am very glad we were able to solve the issue and hopefully no one will need to go through all this angst in the future.
This is potentially a good idea, though it does not influence the changes in /boot/grub2 and /boot/loader that would happen with each kernel update. It only would be of assistance in a situation such as happened here with installing windows after fedora was already installed and the fedora directory in the efi partition was wiped out. Reinstalling grub2 and shim fixes that issue so I am not sure of the benefit.
As shown above, there were actually two issues
The windows install wiped out the fedora efi info, as well as wiping the info for grub boot from the UEFI bios. That necessitated a full grub2 and shim reinstall followed by use of efibootmgr to enable grub booting.
The resultant changes caused LVM to not load and the need to solve the issue with LV activation to enable booting.