F43 Change Proposal: X11Libre (system-wide)

Hello,
I finally got around to making a Fedora account specifically so that I could comment on this proposal.

Right off the bat, I believe that the politics and similar views expressed in the X11libre readme are blatantly against the values Fedora stands for, and that their sheer prevalence in the project means that there is no hope of divorcing the code from the author. Fedora accepting X11Libre into the project would betray its users and imply that Fedora is fine with the statements made in its readme.

However, even putting that all aside, I see technical concerns. Obviously, there’s the fact that a lot of the commits made to X11 by metux before he forked off were found to ultimately cause regressions and not have been tested properly and have been reverted. The issue with the licensing in headers is minor, but also noteworthy given how critical licensing is to FOSS projects (I would know very well myself, given how I’ve had to deal with it in a project that I contribute to in my spare time) and it is not a good look to mess that up so easily (especially the “X11 or MIT” v.s. “X11 and MIT” debacle. The other part is more excusable, that one almost seems deliberate to me). Even more than all of this, however, is something I recently found on X11Libre’s github:

metux did not understand that ^ was not the exponent operator in C. That immediately, to me at least, throws some serious doubts on the quality of the commits made by him (and, to an extent, his ability to properly review PRs). To not know such a key feature of the language the project is largely written in is… frightening, at least to me. It does not inspire confidence in the rest of his code for something as large and low-level as an X11 server, compounding on the existing concerns about his prior commits to xorg having to be reverted for causing regressions.

Outright replacing the xorg X11 server with X11Libre already is also baffling to me. It seems like the logical choice would be to package X11Libre as an alternative to xorg, and only consider after at least one release of the two both being available whether to replace the default for the next release.

10 Likes